Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and validate backup_selection conditions suboptions #1633

Conversation

hakbailey
Copy link
Contributor

@hakbailey hakbailey commented Jun 30, 2023

SUMMARY

Adds documentation and validation for all conditions suboptions in backup_selection module. Fixes #1613

Additionally fixes a bug in module_utils.backup that caused an empty list to be returned from get_selection_details() when multiple backup selections exist for a given backup plan.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

backup_selection
module_utils.backup

ADDITIONAL INFORMATION

See #1613 for detailed description of related issue.

@hakbailey
Copy link
Contributor Author

I'm not sure if this is better characterized as a minor change or a bugfix. Let me know if I should change it.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/5d066b1eabc5430f928716de22efc06c

✔️ ansible-galaxy-importer SUCCESS in 4m 21s
✔️ build-ansible-collection SUCCESS in 12m 57s
✔️ ansible-test-splitter SUCCESS in 5m 16s
✔️ integration-amazon.aws-1 SUCCESS in 5m 56s
Skipped 43 jobs

@github-actions
Copy link

github-actions bot commented Jun 30, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/309b503ef11344b1a6ccb49dfae442c6

✔️ ansible-galaxy-importer SUCCESS in 4m 07s
✔️ build-ansible-collection SUCCESS in 12m 33s
✔️ ansible-test-splitter SUCCESS in 5m 01s
✔️ integration-amazon.aws-1 SUCCESS in 8m 39s
Skipped 43 jobs

@hakbailey hakbailey marked this pull request as draft June 30, 2023 17:59
@hakbailey hakbailey marked this pull request as ready for review June 30, 2023 18:39
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a3623b4cdfbc42e697073e2fea54fa83

✔️ ansible-galaxy-importer SUCCESS in 4m 16s
✔️ build-ansible-collection SUCCESS in 14m 29s
✔️ ansible-test-splitter SUCCESS in 4m 44s
✔️ integration-amazon.aws-1 SUCCESS in 8m 44s
✔️ integration-amazon.aws-2 SUCCESS in 8m 11s
✔️ integration-amazon.aws-3 SUCCESS in 5m 51s
✔️ integration-amazon.aws-4 SUCCESS in 7m 30s
Skipped 40 jobs

@alinabuzachis alinabuzachis added the backport-6 PR should be backported to the stable-6 branch label Jul 3, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6ca608d92b1b47a7ae00dd968fd3280b

✔️ ansible-galaxy-importer SUCCESS in 5m 17s
✔️ build-ansible-collection SUCCESS in 13m 10s
✔️ ansible-test-splitter SUCCESS in 5m 14s
✔️ integration-amazon.aws-1 SUCCESS in 6m 26s
✔️ integration-amazon.aws-2 SUCCESS in 6m 47s
✔️ integration-amazon.aws-3 SUCCESS in 6m 17s
✔️ integration-amazon.aws-4 SUCCESS in 6m 03s
Skipped 40 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/49fe9b7c704840b3be689836cc43ad40

✔️ ansible-galaxy-importer SUCCESS in 3m 39s
✔️ build-ansible-collection SUCCESS in 12m 32s
✔️ ansible-test-splitter SUCCESS in 5m 17s
✔️ integration-amazon.aws-1 SUCCESS in 8m 28s
✔️ integration-amazon.aws-2 SUCCESS in 8m 24s
✔️ integration-amazon.aws-3 SUCCESS in 6m 04s
✔️ integration-amazon.aws-4 SUCCESS in 5m 46s
Skipped 40 jobs

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Jul 4, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/ca035018eb93480789aabe759a47156d

✔️ ansible-galaxy-importer SUCCESS in 3m 50s
✔️ build-ansible-collection SUCCESS in 13m 58s
✔️ ansible-test-splitter SUCCESS in 5m 01s
✔️ integration-amazon.aws-1 SUCCESS in 6m 02s
✔️ integration-amazon.aws-2 SUCCESS in 6m 15s
✔️ integration-amazon.aws-3 SUCCESS in 6m 17s
✔️ integration-amazon.aws-4 SUCCESS in 8m 49s
✔️ integration-community.aws-1 SUCCESS in 16m 42s
Skipped 39 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit cfeffe6 into ansible-collections:main Jul 4, 2023
71 checks passed
@patchback
Copy link

patchback bot commented Jul 4, 2023

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/cfeffe665a55e24426bede38afab01c1dfa0cd90/pr-1633

Backported as #1638

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 4, 2023
Document and validate backup_selection conditions suboptions

SUMMARY
Adds documentation and validation for all conditions suboptions in backup_selection module. Fixes #1613
Additionally fixes a bug in module_utils.backup that caused an empty list to be returned from get_selection_details() when multiple backup selections exist for a given backup plan.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
backup_selection
module_utils.backup
ADDITIONAL INFORMATION
See #1613 for detailed description of related issue.

Reviewed-by: Jill R
Reviewed-by: Alina Buzachis
(cherry picked from commit cfeffe6)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jul 4, 2023
…1638)

[PR #1633/cfeffe66 backport][stable-6] Document and validate backup_selection conditions suboptions

This is a backport of PR #1633 as merged into main (cfeffe6).
SUMMARY
Adds documentation and validation for all conditions suboptions in backup_selection module. Fixes #1613
Additionally fixes a bug in module_utils.backup that caused an empty list to be returned from get_selection_details() when multiple backup selections exist for a given backup plan.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
backup_selection
module_utils.backup
ADDITIONAL INFORMATION
See #1613 for detailed description of related issue.

Reviewed-by: Alina Buzachis
@hakbailey hakbailey deleted the backup-selection-conditions branch August 14, 2023 14:57
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…r auto. (ansible-collections#1633)

Addressing Style S3 (ssm_connection) - choose between path, virtual or auto.

SUMMARY
Added the chance of setting up the addressing style for S3 URLs, this fixes ansible-collections#637
ISSUE TYPE


Feature Pull Request

COMPONENT NAME
aws_ssm
ADDITIONAL INFORMATION
I came across this issue when I was trying to connect and execute tasks on a fresh AWS set-up (new S3 bucket + EC2), I'm using the latest (5.1.0) release and Ansible 5.10 (as per pip show).
The issue itself is the same as ansible-collections#637 and the last comment is the fix, there's another PR addressing this issue ansible-collections#786 but is quiet since May
Also AWS seems to be deprecating PATH addressing style: https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#path-style-access
Thanks to timburnet-systematica and james-masson for their initial work on this.

Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-6 PR should be backported to the stable-6 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backup_selection conditions update incorrectly reports changed
3 participants